Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CL System Menu Margins and Removed Hardcoded Offsets #382

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

maodus
Copy link
Contributor

@maodus maodus commented Jul 6, 2024

This PR:

  • Removes all hardcoded position offsets from the System Menu (text positioning should be consistent across all languages and fonts).
  • Fixes margins for menu icons. Previously, small had like 4 and a half icons visible, now it has 5. I updated the paging functionality to account for this. Additionally, margins regarding the beginning and end of system entry icons are now consistent and relative to menu size.
  • Some miscellaneous adjustments like dead code removal and enforcing snprintf.

Overall, this is a QOL update and should make the ARK user experience better, especially for those who use languages other than English. Any additions to the menu should now be seamless with this PR.

@JoseAaronLopezGarcia
Copy link
Contributor

Nice.

@JoseAaronLopezGarcia JoseAaronLopezGarcia merged commit 993fb7a into PSP-Archive:main Jul 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants